Re: [PATCH v2 10/14] USB: ch341: fix coding style

From	Grigori Goronzy <greg@chown.ath.cx>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 10/14] USB: ch341: fix coding style
Date	2016-04-07 03:20 +0200
Message-ID	<rl6M2-4lH-13@gated-at.bofh.it> (permalink)
References	<rjxnk-74U-3@gated-at.bofh.it> <rjxnk-74U-11@gated-at.bofh.it> <rjxGG-7e3-13@gated-at.bofh.it> <rkZUd-7Dl-7@gated-at.bofh.it> <rl0dz-811-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 04/06/2016 08:10 PM, Johan Hovold wrote:
> As Joe already said, we generally don't want indentation-only changes to
> existing code. Just try to stick to the style of the driver (even if
> it's inconsistent at times).
> 

Hm, I don't get it.  I understand that white-space-only changes are
discouraged if they are freestanding and contributors don't follow up
with any change to functionality (as outlined in
development-process/4.Coding), but this is not the case here.  IMHO, if
the style of a module is inconsistent, it should be fixed at some point.
 The kind of policy you are presenting here will in the long run lead to
messy code, and can't be found in any of the official documents (e.g.
CodingStyle, SubmitChecklist, development-process/) either.  It also
encourages mixing white-space changes with patches that change
functionality, which is a bad practice.

I'll just drop the indentation changes. The rest is fine, I guess?

Grigori

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-02 19:20 +0200
  Re: [PATCH v2 10/14] USB: ch341: fix coding style Joe Perches <joe@perches.com> - 2016-04-02 19:40 +0200
    Re: [PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-06 20:00 +0200
      Re: [PATCH v2 10/14] USB: ch341: fix coding style Johan Hovold <johan@kernel.org> - 2016-04-06 20:20 +0200
        Re: [PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-07 03:20 +0200

csiph-web