Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1372720

Re: [PATCH v2 10/14] USB: ch341: fix coding style

Show all headers | View raw

On Wed, Apr 06, 2016 at 07:58:36PM +0200, Grigori Goronzy wrote:
> On 04/02/2016 07:29 PM, Joe Perches wrote:
> > Most of the whitespace only changes are undesired.
>
> Well, the style wasn't very consistent.  I think consistency is
> important.  So I took the liberty of deciding for one style and stuck
> to it.
> 
> > Multi-line statements here are using alignment to
> > open parenthesis which for some is the preferred
> > style.
> 
> I didn't use alignment to open parentheses because that is often
> reducing the usable space per line too much.  So you have to break lines
> a lot and code becomes less readable.
> 
> Of course, I'm open to arguments if and why a particular style should be
> preferred.  Maybe we should try to mostly avoid these bikeshed
> discussions though. :)

As Joe already said, we generally don't want indentation-only changes to
existing code. Just try to stick to the style of the driver (even if
it's inconsistent at times).

Thanks,
Johan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-02 19:20 +0200
  Re: [PATCH v2 10/14] USB: ch341: fix coding style Joe Perches <joe@perches.com> - 2016-04-02 19:40 +0200
    Re: [PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-06 20:00 +0200
      Re: [PATCH v2 10/14] USB: ch341: fix coding style Johan Hovold <johan@kernel.org> - 2016-04-06 20:20 +0200
        Re: [PATCH v2 10/14] USB: ch341: fix coding style Grigori Goronzy <greg@chown.ath.cx> - 2016-04-07 03:20 +0200

csiph-web