Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370851

Re: [PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

Show all headers | View raw

On 2016-04-04 04:14 PM, David Miller wrote:
> From: Bastien Philbert <bastienphilbert@gmail.com>
> Date: Sun,  3 Apr 2016 19:04:26 -0400
> 
>> This fixes the incorrect variable assignment on error path in
>> br_sysfs_addbr for when the call to kobject_create_and_add
>> fails to assign the value of -EINVAL to the returned variable of
>> err rather then incorrectly return zero making callers think this
>> function has succeededed due to the previous assignment being
>> assigned zero when assigning it the successful return value of
>> the call to sysfs_create_group which is zero.
>>
>> Signed-off-by: Bastien Philbert <bastienphilbert@gmail.com>
> 
> Applied, but please put a space after the subsystem prefix and the
> colon character in your subject lines in the future.
> 
> Doesn't that really look odd to you, the way you did it? "net:Fix"?
> 
> Doesn't it look more natural, and consistent with what all other
> patch submitters do, if it's "net: Fix"?
> 
> Thanks.
> 
Done, sorry about that :(. Will remember for future patches.
Bastien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-04 01:10 +0200
  Re: [PATCH] bridge:Fix incorrect variable assignment on error path in  br_sysfs_addbr Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-04 22:20 +0200
  Re: [PATCH] bridge:Fix incorrect variable assignment on error path  in br_sysfs_addbr David Miller <davem@davemloft.net> - 2016-04-04 22:20 +0200

csiph-web