Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370311

[PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

Show all headers | View raw

This fixes the incorrect variable assignment on error path in
br_sysfs_addbr for when the call to kobject_create_and_add
fails to assign the value of -EINVAL to the returned variable of
err rather then incorrectly return zero making callers think this
function has succeededed due to the previous assignment being
assigned zero when assigning it the successful return value of
the call to sysfs_create_group which is zero.

Signed-off-by: Bastien Philbert <bastienphilbert@gmail.com>
---
 net/bridge/br_sysfs_br.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index 6b80914..f4d40ed 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -870,6 +870,7 @@ int br_sysfs_addbr(struct net_device *dev)
 
 	br->ifobj = kobject_create_and_add(SYSFS_BRIDGE_PORT_SUBDIR, brobj);
 	if (!br->ifobj) {
+		err = -EINVAL;
 		pr_info("%s: can't add kobject (directory) %s/%s\n",
 			__func__, dev->name, SYSFS_BRIDGE_PORT_SUBDIR);
 		goto out3;
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-04 01:10 +0200
  Re: [PATCH] bridge:Fix incorrect variable assignment on error path in  br_sysfs_addbr Bastien Philbert <bastienphilbert@gmail.com> - 2016-04-04 22:20 +0200
  Re: [PATCH] bridge:Fix incorrect variable assignment on error path  in br_sysfs_addbr David Miller <davem@davemloft.net> - 2016-04-04 22:20 +0200

csiph-web