Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration
Date	Mon, 04 Apr 2016 16:20:02 +0200
Message-ID	<rkdwe-4bf-21@gated-at.bofh.it> (permalink)
References	<rj4Y2-35K-9@gated-at.bofh.it> <rj4Y3-35K-47@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=q99KFHU1ODMVngAm7GK225s2tBwf4wMPE2ymDX32E+I=; b=hJKpX0HYlgm23AH29cDrvFTQzthZpRnsvSVpMMKRuQaLNc1VWf2V/yMj/CsyCC5mJy RBxm7wOj/+W+kbE3MyswHqdibfy6bxfr9JgqAbniNBwV3wI5ASUWmRKu6T5LT7zbavcp JpSc4pETnsKTQE7JHs1ONJzdL/vb7phVXBypg=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=q99KFHU1ODMVngAm7GK225s2tBwf4wMPE2ymDX32E+I=; b=VW+QPqZd0I42lchbD+1nxs1CNfBvYNu1PFXspJERamHdcbIpbYY3K25kRpGQKBWfr3 eyxW5yTIVMScEl48KgXiPqtnuulwG6TUT6ODYVHa51cEc61L/yzfgP7e8nwRcJNxnRAq +iatlz1YuDIrtvba2eiVwML0UKfugL6q3y3VksW7DwJw/6kFwZx63NztrdkjCzyT9sIm 2RlhYl0AQHVl59CjG3p+0/cHxBoVywUk7oeE+/gSvF/6NqHDUInRu4GhdAp2dK3uQJTA 1lPEDJ1ya80wE3Iy16LwWAHiKQpbhBa6hZDPT+R47BLncKjugGe/3w+AT7IGBGU3l4Gz Qn5Q==
X-Gm-Message-State	AD7BkJLX6J9NGrHlhJuFVb+VeSZpeR4tLPxKA9rdzPQlWqWWH+sUbbSh6HzMcZaEplBlX2KZb0KxUjpx6Pju13Do
MIME-Version	1.0
X-Received	by 10.157.13.233 with SMTP id 96mr14550567ots.126.1459779453648; Mon, 04 Apr 2016 07:17:33 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	Mathias Nyman <mathias.nyman@linux.intel.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Irina Tirdea <irina.tirdea@intel.com>, Octavian Purdila <octavian.purdila@intel.com>
X-Original-Date	Mon, 4 Apr 2016 16:17:33 +0200
X-Original-Message-ID	<CACRpkdZUbO6yTkh67fZwhjd9DmMU7ZuF9xOM8bgu-O9jVaYcmA@mail.gmail.com>
X-Original-References	<1459508407-22011-1-git-send-email-cristina.ciocan@intel.com> <1459508407-22011-7-git-send-email-cristina.ciocan@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1370660

Show key headers only | View raw

On Fri, Apr 1, 2016 at 1:00 PM, Cristina Ciocan
<cristina.ciocan@intel.com> wrote:

> Make debounce setting and getting functionality available when
> configurating a certain pin.
>
> Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>

Patch applied.

And as this is another case where GPIO has a debounce
setting call: gpiod_set_debounce() this is another case for
my suggested pinctrl_gpio_set_config() as that call is
currently not implemented in your corresponding .set_debounce()
callback for the GPIO chip, but could easily be handled
by calling back into the pinctrl back-end, right?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Linus Walleij <linus.walleij@linaro.org> - 2016-04-04 16:20 +0200
  Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Cristina Ciocan <cristina.ciocan@intel.com> - 2016-04-05 13:20 +0200

csiph-web