Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370660 > unrolled thread

Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Linus Walleij <linus.walleij@linaro.org> - 2016-04-04 16:20 +0200
    Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration Cristina Ciocan <cristina.ciocan@intel.com> - 2016-04-05 13:20 +0200

#1370660 — Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration

On Fri, Apr 1, 2016 at 1:00 PM, Cristina Ciocan
<cristina.ciocan@intel.com> wrote:

> Make debounce setting and getting functionality available when
> configurating a certain pin.
>
> Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>

Patch applied.

And as this is another case where GPIO has a debounce
setting call: gpiod_set_debounce() this is another case for
my suggested pinctrl_gpio_set_config() as that call is
currently not implemented in your corresponding .set_debounce()
callback for the GPIO chip, but could easily be handled
by calling back into the pinctrl back-end, right?

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1371396

On 04.04.2016 17:17, Linus Walleij wrote:
> On Fri, Apr 1, 2016 at 1:00 PM, Cristina Ciocan
> <cristina.ciocan@intel.com> wrote:
> 
>> Make debounce setting and getting functionality available when
>> configurating a certain pin.
>>
>> Signed-off-by: Cristina Ciocan <cristina.ciocan@intel.com>
> 
> Patch applied.
> 
> And as this is another case where GPIO has a debounce
> setting call: gpiod_set_debounce() this is another case for
> my suggested pinctrl_gpio_set_config() as that call is
> currently not implemented in your corresponding .set_debounce()
> callback for the GPIO chip, but could easily be handled
> by calling back into the pinctrl back-end, right?
> 

Yes, it can be easily handled by calling back byt_pin_config_set. I will
look into what other options are often used and would make sense to be
exported in the gpio layer as well and come back with a more detailed
answer.

Thanks

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web