Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370639

Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220

From Leo Yan <leo.yan@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220
Date 2016-04-04 16:10 +0200
Message-ID <rkdmy-47v-3@gated-at.bofh.it> (permalink)
References (2 earlier) <rjVSF-8av-5@gated-at.bofh.it> <rk1Op-3S6-3@gated-at.bofh.it> <rkaRH-2fN-3@gated-at.bofh.it> <rkd3c-3J0-27@gated-at.bofh.it> <rkdcS-3MD-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 04, 2016 at 03:53:47PM +0200, Linus Walleij wrote:
> On Mon, Apr 4, 2016 at 3:42 PM, Leo Yan <leo.yan@linaro.org> wrote:
> > On Mon, Apr 04, 2016 at 01:21:00PM +0200, Linus Walleij wrote:

[...]

> > Also have checked Hi6220's spec, there have no timer's dediated clock
> > enabling bits. This is the reason before I only registered one clock.
> > So according to you and Rob's comments, how about change as below?
> >
> >                 dual_timer0: timer@f8008000 {
> >                         compatible = "arm,sp804", "arm,primecell";
> >                         reg = <0x0 0xf8008000 0x0 0x1000>;
> >                         interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
> >                                      <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
> >                         clocks = <&ao_ctrl HI6220_TIMER0_PCLK>,
> >                                  <&ao_ctrl HI6220_TIMER0_PCLK>,
> >                                  <&ao_ctrl HI6220_TIMER0_PCLK>;
> >                         clock-names = "apb_pclk", "apb_pclk", "apb_pclk";
> 
> This works for me, though I think only the last name
> matters so I would name the first two "timer1" and "timer2".

Will fix to "timer1" and "timer2" and sent out new patch.

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Linus Walleij <linus.walleij@linaro.org> - 2016-04-03 21:30 +0200
  Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Leo Yan <leo.yan@linaro.org> - 2016-04-04 03:50 +0200
    Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Linus Walleij <linus.walleij@linaro.org> - 2016-04-04 13:30 +0200
      Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Leo Yan <leo.yan@linaro.org> - 2016-04-04 15:50 +0200
        Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Linus Walleij <linus.walleij@linaro.org> - 2016-04-04 16:00 +0200
          Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Leo Yan <leo.yan@linaro.org> - 2016-04-04 16:10 +0200
  Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Rob Herring <robh@kernel.org> - 2016-04-04 07:20 +0200

csiph-web