Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

From	Kent Overstreet <kent.overstreet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs
Date	2016-04-06 03:20 +0200
Message-ID	<rkKit-4nJ-1@gated-at.bofh.it> (permalink)
References	<rkDh0-7Hy-13@gated-at.bofh.it> <rkJFM-3PD-11@gated-at.bofh.it> <rkJZ7-3Wx-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 06, 2016 at 08:59:31AM +0800, Ming Lei wrote:
> On Wed, Apr 6, 2016 at 8:30 AM, Kent Overstreet
> <kent.overstreet@gmail.com> wrote:
> > On Wed, Apr 06, 2016 at 01:44:06AM +0800, Ming Lei wrote:
> >> After arbitrary bio size is supported, the incoming bio may
> >> be very big. We have to split the bio into small bios so that
> >> each holds at most BIO_MAX_PAGES bvecs for safety reason, such
> >> as bio_clone().
> >>
> >> This patch fixes the following kernel crash:
> >
> > Ming, let's not do it this way; drivers that don't clone biovecs are the norm -
> > instead, md has its own queue limits that it ought to be setting up correctly.
> 
> Except for md, there are also several usages of bio_clone:
> 
>          - drbd
>          - osdblk
>          - pktcdvd
>          - xen-blkfront
>          - verify code of bcache
> 
> I don't like bio_clone() too, which can cause trouble to multipage bvecs.
> 
> How about fixing the issue by this simple patch first? Then once we limits
> all above queues by max sectors, the global limit can be removed as
> mentioned by the comment.

just do this:

void blk_set_limit_clonable(struct queue_limits *lim)
{
	lim->max_segments = min(lim->max_segments, BIO_MAX_PAGES);
}

and then call that from the appropriate drivers. It should be like 20 minutes of
work.

My issue is that your approach of just enforcing a global limit is a step in the
wrong direction - we want to get _away_ from that and move towards drivers
specifying _directly_ what their limits are: more straightforward, less opaque.

Also, your patch is wrong, as it'll break if there's bvecs that aren't full
pages.

Thread

[PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-05 19:50 +0200
  Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Shaohua Li <shli@fb.com> - 2016-04-05 20:30 +0200
    Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 02:30 +0200
      Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 02:40 +0200
        Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 02:50 +0200
          Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 03:10 +0200
          Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Shaohua Li <shli@fb.com> - 2016-04-06 03:10 +0200
        Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Shaohua Li <shli@fb.com> - 2016-04-06 02:50 +0200
      Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Shaohua Li <shli@fb.com> - 2016-04-06 02:40 +0200
    Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 02:50 +0200
      Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Shaohua Li <shli@fb.com> - 2016-04-06 03:10 +0200
        Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 03:20 +0200
  Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 02:40 +0200
    Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 03:00 +0200
      Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 03:20 +0200
        Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 03:30 +0200
          Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 03:30 +0200
            Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 04:00 +0200
              Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 04:30 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 04:40 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 04:50 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 05:00 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 05:00 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Kent Overstreet <kent.overstreet@gmail.com> - 2016-04-06 04:40 +0200
                Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 04:40 +0200
  Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-06 03:10 +0200
    Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Eric Wheeler <bcache@lists.ewheeler.net> - 2016-04-07 03:50 +0200
  Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Eric Wheeler <bcache@lists.ewheeler.net> - 2016-04-07 03:40 +0200
    Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-07 03:50 +0200
      Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Eric Wheeler <bcache@lists.ewheeler.net> - 2016-04-07 04:00 +0200
        Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-07 04:20 +0200
          Re: [PATCH] block: make sure big bio is splitted into at most 256  bvecs Eric Wheeler <bcache@lists.ewheeler.net> - 2016-04-08 01:30 +0200
            Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-08 02:30 +0200

csiph-web