Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371779

Re: [PATCH] iommu/rockchip: Only log stall errors when attaching

Show all headers | View raw

Am Dienstag, 5. April 2016, 16:57:26 schrieb Joerg Roedel:
> On Tue, Mar 22, 2016 at 04:04:33PM +0100, Tomeu Vizoso wrote:
> > Move the logging of timeouts when stalling the MMU to
> > rk_iommu_attach_device, as it's expected that sometimes the MMU won't
> > get stalled when detaching a device, and it's not a real problem that
> > would need to be communicated to the user.
> > 
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> 
> Heiko, any opinion on this patch?

I don't know enough about iommus (and the rockchip implementation) to judge 
if this is correct. The reasoning sound right though and it seems to fix an 
issue for Tomeu.

One complaint would be that I'd expect the behaviour to match between the 
enable and disable functions. Meaning I'd want the error message from 
rk_iommu_disable_stall to also move rk_iommu_attach_device.


Heiko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iommu/rockchip: Only log stall errors when attaching Joerg Roedel <joro@8bytes.org> - 2016-04-05 17:00 +0200
  Re: [PATCH] iommu/rockchip: Only log stall errors when attaching Heiko Stuebner <heiko@sntech.de> - 2016-04-05 18:50 +0200
    Re: [PATCH] iommu/rockchip: Only log stall errors when attaching Heiko Stuebner <heiko@sntech.de> - 2016-04-05 19:20 +0200

csiph-web