Re: [PATCH] drivers/iommu: don't select DEBUG_FS for AMD_IOMMU_STATS

Path	csiph.com!goblin3!goblin.stu.neva.ru!sewer!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/iommu: don't select DEBUG_FS for AMD_IOMMU_STATS
Date	Tue, 05 Apr 2016 18:40:01 +0200
Message-ID	<rkCbf-6W6-9@gated-at.bofh.it> (permalink)
References	<rh7x0-Ue-3@gated-at.bofh.it> <rkB5w-5V6-13@gated-at.bofh.it>
X-Original-To	Joerg Roedel <joro@8bytes.org>
X-Session-Marker	726F737465647440676F6F646D69732E6F7267
X-Spam-Summary	2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2693:2894:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12517:12519:12740:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:30054:30062:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none
X-He-Tag	year49_2869020519a03
X-Filterd-Recvd-Size	2442
X-Mailer	Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Paul Gortmaker <paul.gortmaker@windriver.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
X-Original-Date	Tue, 5 Apr 2016 12:37:54 -0400
X-Original-Message-ID	<20160405123754.30786ede@grimm.local.home>
X-Original-References	<1459041524-30929-1-git-send-email-paul.gortmaker@windriver.com> <20160405151951.GG11519@8bytes.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1371778

Show key headers only | View raw

On Tue, 5 Apr 2016 17:19:51 +0200
Joerg Roedel <joro@8bytes.org> wrote:

> On Sat, Mar 26, 2016 at 09:18:44PM -0400, Paul Gortmaker wrote:
> > We have at least one big banner telling people that they should
> > not deploy production kernels with DEBUG options enabled, but
> > at the same time, we make it hard for people to turn DEBUG_FS
> > off when we select (vs. depend on) the CONFIG_DEBUG_FS option.
> > 
> > Since we actively discourage people using debug-like features
> > on any builds that are production oriented (see trace_printk
> > banner for one example), so a generic sounding option should
> > not select DEBUG_FS.  
> 
> That reasoning sounds a bit odd, as most production kernels have
> DEBUG_FS enabled anyway, and I see no problem with that.
> 
> Disabling all debug features in 'production kernels' is a bit overkill.
> Only if the feature has any runtime impact (performance, memory
> consumption, security, ...) it makes sense to disable it for production
> kernels.
> 
> Other features could stay enabled, and DEBUG_FS is one of them. For some
> debug features we even don't offer a way to disable them, see BUG_ON,
> WARN_ON and friends.
> 

I will argue that people have asked me to move tracing out of debugfs
(which is why I created tracefs) because the problem with debugfs is
that it opens up a entire system that is not well scrutinized, and
holds lots of possible ways to crack the kernel.

Disabling debugfs does help with the "security" point you mentioned
above.

-- Steve

Thread

Re: [PATCH] drivers/iommu: don't select DEBUG_FS for AMD_IOMMU_STATS Joerg Roedel <joro@8bytes.org> - 2016-04-05 17:30 +0200
  Re: [PATCH] drivers/iommu: don't select DEBUG_FS for  AMD_IOMMU_STATS Steven Rostedt <rostedt@goodmis.org> - 2016-04-05 18:40 +0200
    Re: [PATCH] drivers/iommu: don't select DEBUG_FS for AMD_IOMMU_STATS Joerg Roedel <joro@8bytes.org> - 2016-04-06 00:50 +0200

csiph-web