Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370474

Re: lockdep WARNING in get_online_cpus

Show all headers | View raw

On Mon, Apr 04, 2016 at 10:19:05AM +0200, Dmitry Vyukov wrote:
> 
> This happens in CONFIG_DEBUG_LOCKDEP code. Is it a bug in lockdep?

We hope not; but it is a new test.

So lockdep needs to check each current lock stack against the recorded
lock dependencies to see if we've gotten ourselves a cycle. Doing this
check is _expensive_.

So what lockdep does is it computes a hash for each lock stack and only
if we've not seen this hash before (actually truncated since we don't
have a full 64bit hashtable) do we go look for cycles.

The new check tries to detect hash-collisions in this cache. A collision
would result in not checking for cycles, even if we've not seen the
stack before.

You've managed to tickle this.

Now, last week I found some bugs in there, and Alfredo added a pretty
printer, so maybe try and add these patches to your testing?

  git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/urgent

> But I always see at the same stack involving perf and jump_label...

So you have a simple reproducer? So that I can have a go at this.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

lockdep WARNING in get_online_cpus Dmitry Vyukov <dvyukov@google.com> - 2016-04-02 15:10 +0200
  Re: lockdep WARNING in get_online_cpus Dmitry Vyukov <dvyukov@google.com> - 2016-04-04 10:20 +0200
    Re: lockdep WARNING in get_online_cpus Peter Zijlstra <peterz@infradead.org> - 2016-04-04 11:10 +0200
      Re: lockdep WARNING in get_online_cpus Dmitry Vyukov <dvyukov@google.com> - 2016-04-04 12:00 +0200
        Re: lockdep WARNING in get_online_cpus Peter Zijlstra <peterz@infradead.org> - 2016-04-05 11:50 +0200
          Re: lockdep WARNING in get_online_cpus Dmitry Vyukov <dvyukov@google.com> - 2016-04-05 11:50 +0200
            Re: lockdep WARNING in get_online_cpus Peter Zijlstra <peterz@infradead.org> - 2016-04-05 13:20 +0200
              Re: lockdep WARNING in get_online_cpus Dmitry Vyukov <dvyukov@google.com> - 2016-04-05 13:30 +0200

csiph-web