Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370475

Re: [PATCH 02/11] locking, rwsem: drop explicit memory barriers

Show all headers | View raw

On Fri 01-04-16 18:17:53, Davidlohr Bueso wrote:
[...]
> I think we can actually get rid of these files altogether. While I
> don't know the archs, it does not appear to be implementing any kind
> of workaround/optimization, which is obviously the whole purpose of
> defining per-arch rwsem internals, unless the redundant barriers are
> actually the purpose. So we could use the generic rwsem.h (which has
> optimizations and ACQUIRE/ RELEASE semantics, although nops for either
> sh or xtensa specifically). A first inspection shows that the code is
> in fact the same and continue to use 32bit rwsems.

OK, so this has passed my defconfig and allnoconfig for xtensa compile
test, allyesconfig has failed due to some unrelated reasons:
clk-qoriq.c:(.init.text+0x3ebd3): dangerous relocation: l32r: literal target out of range (try using text-section-literals): (.init.literal+0x17c60)
and zillions of similar... The same error is without the patch

I do not have a crosscompiler[1] for sh arch so I couldn't have tested
it but there shouldn't be any issues in principal. I will send two
patches as a follow up.

---
[1] https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/ doesn't
seem to have it.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/11] introduce down_write_killable for rw_semaphore v2 Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 11/11] locking, rwsem: provide down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 10/11] x86, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
    Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Peter Zijlstra <peterz@infradead.org> - 2016-04-06 20:40 +0200
  [PATCH 04/11] alpha, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 01/11] locking, rwsem: get rid of __down_write_nested Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
    Re: [PATCH 01/11] locking, rwsem: get rid of __down_write_nested Davidlohr Bueso <dave@stgolabs.net> - 2016-04-02 02:30 +0200
  [PATCH 02/11] locking, rwsem: drop explicit memory barriers Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
    Re: [PATCH 02/11] locking, rwsem: drop explicit memory barriers Davidlohr Bueso <dave@stgolabs.net> - 2016-04-02 03:20 +0200
      Re: [PATCH 02/11] locking, rwsem: drop explicit memory barriers Michal Hocko <mhocko@kernel.org> - 2016-04-04 11:10 +0200
        [PATCH 2/2] sh, rwsem: drop superfluous arch specific implementation Michal Hocko <mhocko@kernel.org> - 2016-04-04 11:10 +0200
          Re: [PATCH 2/2] sh, rwsem: drop superfluous arch specific  implementation Peter Zijlstra <peterz@infradead.org> - 2016-04-06 11:30 +0200
            Re: [PATCH 2/2] sh, rwsem: drop superfluous arch specific implementation Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-06 12:00 +0200
              Re: [PATCH 2/2] sh, rwsem: drop superfluous arch specific  implementation Peter Zijlstra <peterz@infradead.org> - 2016-04-06 12:30 +0200
        [PATCH 1/2] xtensa, rwsem: drop superfluous arch specific implementation Michal Hocko <mhocko@kernel.org> - 2016-04-04 11:10 +0200
          Re: [PATCH 1/2] xtensa, rwsem: drop superfluous arch specific implementation Max Filippov <jcmvbkbc@gmail.com> - 2016-04-04 12:30 +0200
      [PATCH] sparc, rwsem: drop superfluous arch specific implementation Michal Hocko <mhocko@kernel.org> - 2016-04-06 11:10 +0200
  [PATCH 07/11] sh, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 08/11] sparc, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 05/11] ia64, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200
  [PATCH 06/11] s390, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:10 +0200

csiph-web