Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1370088

Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors

Show all headers | View raw

On Fri, Apr 01, 2016 at 10:31:34AM -0500, Rob Herring wrote:
> On Fri, Apr 1, 2016 at 1:57 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > Fix following DTC warnings in cros-adc-thermistors:
> > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@3 has a unit name, but no reg property
> > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@4 has a unit name, but no reg property
> > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@5 has a unit name, but no reg property
> > Warning (unit_address_vs_reg): Node /adc@12D10000/ncp15wb473@6 has a unit name, but no reg property
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> >  arch/arm/boot/dts/cros-adc-thermistors.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/cros-adc-thermistors.dtsi b/arch/arm/boot/dts/cros-adc-thermistors.dtsi
> > index acd4fe1833f2..87e676917603 100644
> > --- a/arch/arm/boot/dts/cros-adc-thermistors.dtsi
> > +++ b/arch/arm/boot/dts/cros-adc-thermistors.dtsi
> > @@ -13,28 +13,28 @@
> >  */
> >
> >  &adc {
> > -       ncp15wb473@3 {
> > +       ncp15wb473_3 {
> 
> Don't use underscores.

The ePAPR lists underscore as a acceptable character... but if you
insists then the sensible solution would be to rename all the nodes to
something like:
-       ncp15wb473@3 {
+       thermistor3 {

Is it okay?

> 
> >                 compatible = "murata,ncp15wb473";
> >                 pullup-uv = <1800000>;
> >                 pullup-ohm = <47000>;
> >                 pulldown-ohm = <0>;
> >                 io-channels = <&adc 3>;
> 
> I've not looked at the full binding here, but this case may warrant
> adding a reg property as an ADC channel number is what i'd consider an
> addressable thing.

This does not look entirely as an addressable thing. Altough this
particular driver (ntc_thermistor.c) uses one iio-channel... but others
are often using more than one.

> This is also kind of strange having a phandle to
> the parent node.

The Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
mentions that sensors can be added as child nodes or separately. The
exynos_adc driver indeed calls of_platform_populate() but I am not sure
why this was added.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in  cros-adc-thermistors Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 07/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos542x Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 08/11] ARM: dts: exynos: Fix DTC unit name warnings in Peach Pit Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2  board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in  Trats2 board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 10:20 +0200
    Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in  Trats2 board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:40 +0200
  [PATCH 10/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5440 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos3250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos3250 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:30 +0200
  [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos4 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:40 +0200
  [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in S5Pv210  boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in  S5Pv210 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 20:00 +0200
  [PATCH 09/11] ARM: dts: exynos: Fix DTC unit name warnings in SMDK5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 05/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos4x12 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:10 +0200
  [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:10 +0200
    Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5250 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 19:30 +0200
      Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-03 05:10 +0200
  Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in  cros-adc-thermistors Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:30 +0200
  Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Rob Herring <robh+dt@kernel.org> - 2016-04-01 17:40 +0200
    Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in  cros-adc-thermistors Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-03 05:50 +0200

csiph-web