Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369381

Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2 board

Show all headers | View raw

Hello Krzysztof,

On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote:
> Fix following DTC warnings in Trats2 board:
> 
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT1@1 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT2@2 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/CHARGER@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /thermistor-ap@0 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /thermistor-battery@1 has a unit name, but no reg property
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-trats2.dts | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 2bf363c3bf62..523627003738 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -29,7 +29,7 @@
>  		i2c12 = &i2c_max77693_fuel;
>  	};
>  
> -	memory {
> +	mmemory@40000000 {
>  		reg =  <0x40000000 0x40000000>;
>  	};
> 

Besides this creating duplicated memory nodes as you said, plain memory
should be allowed according to Rob and he plans to add an exception to dtc:

http://www.spinics.net/lists/arm-kernel/msg494038.html
 
Rest of the patch looks good so after removing the memory node change:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in  cros-adc-thermistors Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 07/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos542x Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 08/11] ARM: dts: exynos: Fix DTC unit name warnings in Peach Pit Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2  board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in  Trats2 board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 10:20 +0200
    Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in  Trats2 board Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:40 +0200
  [PATCH 10/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5440 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos3250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 02/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos3250 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:30 +0200
  [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in Exynos4 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 03/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos4 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:40 +0200
  [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in S5Pv210  boards Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
    Re: [PATCH 11/11] ARM: dts: s5p: Fix DTC unit name warnings in  S5Pv210 boards Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 20:00 +0200
  [PATCH 09/11] ARM: dts: exynos: Fix DTC unit name warnings in SMDK5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:00 +0200
  [PATCH 05/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos4x12 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:10 +0200
  [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 09:10 +0200
    Re: [PATCH 06/11] ARM: dts: exynos: Fix DTC unit name warnings in  Exynos5250 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 19:30 +0200
  Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in  cros-adc-thermistors Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-01 16:30 +0200
  Re: [PATCH 01/11] ARM: dts: exynos: Fix DTC unit name warnings in cros-adc-thermistors Rob Herring <robh+dt@kernel.org> - 2016-04-01 17:40 +0200

csiph-web