Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369437

RE: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef

Show all headers | View raw

>Question about removing lustre typedefs.
>
>Various bits of lustre code use a mix of struct foo and foo_t.
>
>When would be an appropriate time to submit patches similar to
>below that individually remove various typedefs from lustre code?
>
>These are pretty trivial to produce and verify so there's no
>particular hurry to do them now but applying them will require
>resync points for active and actually useful developers.

Actually could you hold off for the LNet core and LND drivers these
changes. I have plans to push a few more LNet patches soon. I have
been just waiting for everyone to figure out how to deal with the 
latest changes to the infinband layer first. So the plan is to push
FMR support for the ko2iblnd driver. Also we have additional work
too handle setting the size of the DMA pools for o2iblnd but that
patch touches some of the core LNet code as well. Once those are
landed we can look at removing most of the typedefs. When its
time for the typedef to be cleaned up lets do just the structs first.
There are a few typedefs like lnet_nid_t I like to keep or if it has to
be changed turn it into a struct then. Things like lnet_nid_t act like
a cookie handle.

Now the best place to do this cleanup right now is LNet selftest. No
new code is planned for landing. We have lots of typedefs to remove
and I was planning to do that cleanup but if you want to do it just CC
me, jsimmons@infradead.org, so I can test the changes.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] staging: lustre: detypedef Joe Perches <joe@perches.com> - 2016-04-01 15:10 +0200
  [RFC PATCH 2/3] staging: lustre: Remove typedef lnd_t Joe Perches <joe@perches.com> - 2016-04-01 15:10 +0200
  [RFC PATCH 1/3] staging: lustre: Remove typedef lnet_peer_t Joe Perches <joe@perches.com> - 2016-04-01 15:10 +0200
  [RFC PATCH 3/3] staging: lustre: Remove typedef lnet_msg_t Joe Perches <joe@perches.com> - 2016-04-01 15:10 +0200
  Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-04-01 16:30 +0200
    Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Joe Perches <joe@perches.com> - 2016-04-01 20:50 +0200
      Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-04-01 21:20 +0200
        Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Joe Perches <joe@perches.com> - 2016-04-01 21:30 +0200
      Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef James Simmons <jsimmons@infradead.org> - 2016-04-01 22:00 +0200
      Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypede James Simmons <jsimmons@infradead.org> - 2016-04-01 22:10 +0200
  RE: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef "Simmons, James A." <simmonsja@ornl.gov> - 2016-04-01 18:00 +0200
    Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef Joe Perches <joe@perches.com> - 2016-04-01 21:00 +0200

csiph-web