Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367515

Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 30, 2016 at 11:17:09AM -0700, Stephen Boyd wrote:

> This is for the qcom spmi regulator driver. I seem to have put in the
> set_voltage_time_sel op but missed the fact that the regulator core
> wasn't calling that op to find out how much time to delay. So we have
> raw voltage set and get ops and this selector based delay op.

> Do we need to change the ops to be selector based if we want the
> regulator core to delay after changing voltages? Or do we need to put
> the delay directly into the set_voltage() op in the driver?

You need a consistent set of operations.  If you want to use raw
voltages you need to add a raw voltage interface for getting the delay,
not mix selector and non-selector interfaces otherwise we'll run into
problems.  It is not sensible to expect a driver that does not use
selectors to implement selectors for some operations, if a driver *does*
use selectors then it should do so consistently.  The latter is probably
the more sensible option for this driver since it does have a list
operation so does understand selectors.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Georgi Djakov <georgi.djakov@linaro.org> - 2016-03-30 16:30 +0200
  Re: [PATCH] regulator: Support ramp-up delay for drivers with  get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 19:40 +0200
    Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Stephen Boyd <stephen.boyd@linaro.org> - 2016-03-30 20:20 +0200
      Re: [PATCH] regulator: Support ramp-up delay for drivers with  get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 20:40 +0200
        Re: [PATCH] regulator: Support ramp-up delay for drivers with  get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 22:50 +0200

csiph-web