Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367490
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() |
| Date | 2016-03-30 19:40 +0200 |
| Message-ID | <risg3-jV-23@gated-at.bofh.it> (permalink) |
| References | <ripia-6GA-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Mar 30, 2016 at 05:23:12PM +0300, Georgi Djakov wrote:
> + } else if (_regulator_is_enabled(rdev) &&
> + rdev->desc->ops->set_voltage_time_sel &&
> + rdev->desc->ops->get_voltage) {
> + int uV = rdev->desc->ops->get_voltage(rdev);
> +
> + if (uV > 0) {
> + old_selector = regulator_map_voltage(rdev, uV, uV);
> + if (old_selector < 0)
> + return old_selector;
> + }
If a driver is using selectors it should use selectors uninformly, it
should not mix and match selector and raw voltage interfaces. If we
the set and get operations are not symmetric I'd expect we're going to
run into problems sooner rather than later.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Georgi Djakov <georgi.djakov@linaro.org> - 2016-03-30 16:30 +0200
Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 19:40 +0200
Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Stephen Boyd <stephen.boyd@linaro.org> - 2016-03-30 20:20 +0200
Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 20:40 +0200
Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() Mark Brown <broonie@kernel.org> - 2016-03-30 22:50 +0200
csiph-web