Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367499
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD |
| Date | 2016-03-30 19:50 +0200 |
| Message-ID | <rispJ-nD-19@gated-at.bofh.it> (permalink) |
| References | <ricuC-5QH-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> + if (err) {
> + if (flags & ADDPART_FLAG_WHOLEDISK)
> + goto out_remove_file;
> + goto out_del;
> + }
I'd rather have that if around the actual device_remove_file at the
label, and jump to out_remove_file unconditionally.
Otherwise this looks fine to me.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Ming Lei <ming.lei@canonical.com> - 2016-03-30 02:50 +0200
Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Christoph Hellwig <hch@infradead.org> - 2016-03-30 19:50 +0200
Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Ming Lei <ming.lei@canonical.com> - 2016-03-31 04:30 +0200
csiph-web