Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD

From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD
Date	2016-03-31 04:30 +0200
Message-ID	<riAwV-6pz-9@gated-at.bofh.it> (permalink)
References	<ricuC-5QH-13@gated-at.bofh.it> <rispJ-nD-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 1:43 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> +     if (err) {
>> +             if (flags & ADDPART_FLAG_WHOLEDISK)
>> +                     goto out_remove_file;
>> +             goto out_del;
>> +     }
>
> I'd rather have that if around the actual device_remove_file at the
> label, and jump to out_remove_file unconditionally.

OK, looks better.

>
> Otherwise this looks fine to me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Ming Lei <ming.lei@canonical.com> - 2016-03-30 02:50 +0200
  Re: [PATCH] block: partition: initialize percpuref before sending  out KOBJ_ADD Christoph Hellwig <hch@infradead.org> - 2016-03-30 19:50 +0200
    Re: [PATCH] block: partition: initialize percpuref before sending out KOBJ_ADD Ming Lei <ming.lei@canonical.com> - 2016-03-31 04:30 +0200

csiph-web