Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367368
| From | "Ewan D. Milne" <emilne@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" |
| Date | 2016-03-30 18:30 +0200 |
| Message-ID | <rirak-82U-45@gated-at.bofh.it> (permalink) |
| References | <riiA2-1Vf-15@gated-at.bofh.it> <riiA3-1Vf-49@gated-at.bofh.it> |
| Organization | Red Hat |
On Wed, 2016-03-30 at 09:09 +0200, Johannes Thumshirn wrote:
> This reverts commit 90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/scsi/scsi_sysfs.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 00bc721..4f18a85 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -1272,18 +1272,16 @@ static void __scsi_remove_target(struct scsi_target *starget)
> void scsi_remove_target(struct device *dev)
> {
> struct Scsi_Host *shost = dev_to_shost(dev->parent);
> - struct scsi_target *starget, *last_target = NULL;
> + struct scsi_target *starget;
> unsigned long flags;
>
> restart:
> spin_lock_irqsave(shost->host_lock, flags);
> list_for_each_entry(starget, &shost->__targets, siblings) {
> - if (starget->state == STARGET_DEL ||
> - starget == last_target)
> + if (starget->state == STARGET_DEL)
> continue;
> if (starget->dev.parent == dev || &starget->dev == dev) {
> kref_get(&starget->reap_ref);
> - last_target = starget;
> spin_unlock_irqrestore(shost->host_lock, flags);
> __scsi_remove_target(starget);
> scsi_target_reap(starget);
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND PATCH v2 0/2] Update SCSI target removal path Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
[RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state "Ewan D. Milne" <emilne@redhat.com> - 2016-03-30 18:30 +0200
[RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
Re: [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" "Ewan D. Milne" <emilne@redhat.com> - 2016-03-30 18:30 +0200
Re: [RESEND PATCH v2 0/2] Update SCSI target removal path James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-03-30 18:50 +0200
Re: [RESEND PATCH v2 0/2] Update SCSI target removal path jthumshirn <jthumshirn@suse.de> - 2016-03-31 09:00 +0200
Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Sebastian Herbszt <herbszt@gmx.de> - 2016-03-30 23:50 +0200
Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state jthumshirn <jthumshirn@suse.de> - 2016-03-31 09:30 +0200
csiph-web