Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367904

Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

Show all headers | View raw

Hi Sebastian,

On 2016-03-30 23:44, Sebastian Herbszt wrote:
> Johannes Thumshirn wrote:
>> Add intermediate STARGET_REMOVE state to scsi_target_state to avoid 
>> running
>> into the BUG_ON() in scsi_target_reap().
>> 
>> This intermediate state is only valid in the path from 
>> scsi_remove_target() to
>> scsi_target_destroy() indicating this target is going to be removed.
>> 
>> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>> Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38
>> Cc: stable@vger.kernel.org
>> Reviewed-by: Hannes Reinecke <hare@suse.com>
>> Reviewed-by: Ewan D. Milne <emilne@redhat.com>
>> ---
>> 
>> Changes from v1:
>> * The state transition from STARGET_CREATED to STARGET_DEL is 
>> legitimate,
>>   so don't BUG() on it. Found by the 0-Day Bot.
> 
> This is yet another attempt to fix 40998193560d. Can you please explain 
> how
> it is "superior" to the one proposed by Bart before [1] ?
> 
> [1] http://marc.info/?l=linux-scsi&m=145227191917602&w=2

First of all I didn't oppose Bart's patch.
But let me try explaining mine (in contrast to Bart's).

The patch above expands the current SCSI target state machine, whereas 
Bart's patch removed the target state machine and tied the target states 
to their sysfs representaion, like his patch description explains

[quote]
Instead of representing the states "visible in sysfs" and
"has been removed from the target list" by a single state
variable, use two variables to represent this information.
[/quote]

It is actually the other way round to my patch. The above expands the 
target state machine from (simplified)

CREATED -> RUNNING -> DEL
         \_____________^

to:
CREATED -> RUNNING -> REMOVE -> DEL
         \_______________________^

This intermediate step ensures that scsi_target_reap() is not called 
with a target in the STARGET_DEL state (which causes the BUG_ON() to 
trigger).

As said above, both patches do the same (eliminate the race in the 
target removal path) but differently.

I hope I could answer your questions.

Byte,
     Johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v2 0/2] Update SCSI target removal path Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
  [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
    Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE  state to scsi_target_state "Ewan D. Milne" <emilne@redhat.com> - 2016-03-30 18:30 +0200
  [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-30 09:20 +0200
    Re: [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in  scsi_remove_target() on module removal" "Ewan D. Milne" <emilne@redhat.com> - 2016-03-30 18:30 +0200
  Re: [RESEND PATCH v2 0/2] Update SCSI target removal path James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-03-30 18:50 +0200
    Re: [RESEND PATCH v2 0/2] Update SCSI target removal path jthumshirn <jthumshirn@suse.de> - 2016-03-31 09:00 +0200
  Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE  state to scsi_target_state Sebastian Herbszt <herbszt@gmx.de> - 2016-03-30 23:50 +0200
    Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state  to scsi_target_state jthumshirn <jthumshirn@suse.de> - 2016-03-31 09:30 +0200

csiph-web