Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367343

[PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const

Show all headers | View raw

bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.

Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 include/linux/bvec_iter.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/bvec_iter.h b/include/linux/bvec_iter.h
index 29c459d..9f0dcb2 100644
--- a/include/linux/bvec_iter.h
+++ b/include/linux/bvec_iter.h
@@ -45,7 +45,8 @@
 	.bv_offset	= bvec_iter_offset((bvec), (iter)),	\
 })
 
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+				     struct bvec_iter *iter,
 				     unsigned bytes)
 {
 	WARN_ONCE(bytes > iter->bi_size,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/8] block: prepare for multipage bvecs Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:30 +0200
    Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on  CONFIG_BLOCK Christoph Hellwig <hch@infradead.org> - 2016-03-30 19:20 +0200
      Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-03-31 03:10 +0200
        Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on  CONFIG_BLOCK Christoph Hellwig <hch@infradead.org> - 2016-03-31 10:00 +0200
          Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-04-01 02:40 +0200

csiph-web