Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK

From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK
Date	2016-04-01 02:40 +0200
Message-ID	<riVi2-4Du-7@gated-at.bofh.it> (permalink)
References	<rir0C-7XM-9@gated-at.bofh.it> <rirai-82U-17@gated-at.bofh.it> <rirWF-by-3@gated-at.bofh.it> <rizhv-5tm-1@gated-at.bofh.it> <riFGj-1EX-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 3:52 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 31, 2016 at 09:02:59AM +0800, Ming Lei wrote:
>> That way may cause trouble to blk_type.h because it needs bvec_iter,
>> then looks not good to always include bvec_iter.h into blk_type.h.
>
> I'd expect bvec.h to be always included in blk_types.h, and replace

That should be fine, but blk_types.h will become more fat.

> the inclusion of blk_types.h in fs.h eventually.

I guess it can't be done because fs.h need 'struct bio'.

thanks,
Ming

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/8] block: prepare for multipage bvecs Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:20 +0200
  [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-03-30 18:30 +0200
    Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on  CONFIG_BLOCK Christoph Hellwig <hch@infradead.org> - 2016-03-30 19:20 +0200
      Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-03-31 03:10 +0200
        Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on  CONFIG_BLOCK Christoph Hellwig <hch@infradead.org> - 2016-03-31 10:00 +0200
          Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei <ming.lei@canonical.com> - 2016-04-01 02:40 +0200

csiph-web