Re: [PATCH] MIPS: ath79: fix build failure

From	Antony Pavlov <antonynpavlov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: ath79: fix build failure
Date	2016-03-31 16:10 +0200
Message-ID	<riLsn-6eH-39@gated-at.bofh.it> (permalink)
References	<riqnT-7t2-1@gated-at.bofh.it> <ritON-1xz-1@gated-at.bofh.it> <riwjE-358-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 30 Mar 2016 23:56:18 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Wed, Mar 30, 2016 at 10:13:29PM +0300, Antony Pavlov wrote:
> 
> > It is very strange because my original patch has this closing brace.
> > Please see my original patch
> > https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html
> 
> The patch didn't apply cleanly and I botched resolving it, sorry.  I folded
> the fix into the patch.
> 
> > Also I suppose that we have no need in detect_memory_region() if we use devicetree,
> > e.g.
> > 
> >                 ath79_detect_sys_type();
> >                 ath79_ddr_ctrl_init();
> >  +              detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
> >  +      }
> >   
> >  -      detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
> 
> "suppose" is a bit weak..  Should I move the detect_memory_region call?

I have just examined lastest master from git://git.linux-mips.org/pub/scm/ralf/linux

The problem is a bit more complex. We have to move _machine_restart assignment too.

I'll send fixup in a few seconds.

Also please remove a dot from commit title.

-- 
Best regards,
  Antony Pavlov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: ath79: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-30 17:40 +0200
  Re: [PATCH] MIPS: ath79: fix build failure Antony Pavlov <antonynpavlov@gmail.com> - 2016-03-30 21:20 +0200
    Re: [PATCH] MIPS: ath79: fix build failure Ralf Baechle <ralf@linux-mips.org> - 2016-03-31 00:00 +0200
      Re: [PATCH] MIPS: ath79: fix build failure Antony Pavlov <antonynpavlov@gmail.com> - 2016-03-31 16:10 +0200

csiph-web