Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365128

[PATCH 7/9] drivers/gpio: make gpio-sta2x11.c explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_STA2X11
drivers/gpio/Kconfig:   bool "STA2x11/ConneXt GPIO support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity, so that when reading
the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-sta2x11.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-sta2x11.c b/drivers/gpio/gpio-sta2x11.c
index 0d5b8c525dd9..853ca23cad88 100644
--- a/drivers/gpio/gpio-sta2x11.c
+++ b/drivers/gpio/gpio-sta2x11.c
@@ -20,7 +20,7 @@
  *
  */
 
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/gpio.h>
@@ -432,8 +432,4 @@ static struct platform_driver sta2x11_gpio_platform_driver = {
 	},
 	.probe = gsta_probe,
 };
-
-module_platform_driver(sta2x11_gpio_platform_driver);
-
-MODULE_LICENSE("GPL v2");
-MODULE_DESCRIPTION("sta2x11_gpio GPIO driver");
+builtin_platform_driver(sta2x11_gpio_platform_driver);
-- 
2.6.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
    Re: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly  non-modular Baruch Siach <baruch@tkos.co.il> - 2016-03-27 19:50 +0200
    Re: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 15:10 +0200
  [PATCH 9/9] drivers/gpio: make gpio-zx.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 5/9] drivers/gpio: make gpio-mvebu.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
    Re: [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 12:10 +0200
  [PATCH 4/9] drivers/gpio: make gpio-moxart.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  Re: [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 15:20 +0200

csiph-web