Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365135

[PATCH 5/9] drivers/gpio: make gpio-mvebu.c explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/gpio/Kconfig:config GPIO_MVEBU
drivers/gpio/Kconfig:   def_bool y

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-mvebu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index 11c6582ef0a6..cd5dc27320a2 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -34,7 +34,7 @@
  */
 
 #include <linux/err.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/gpio.h>
 #include <linux/irq.h>
 #include <linux/slab.h>
@@ -557,7 +557,6 @@ static const struct of_device_id mvebu_gpio_of_match[] = {
 		/* sentinel */
 	},
 };
-MODULE_DEVICE_TABLE(of, mvebu_gpio_of_match);
 
 static int mvebu_gpio_suspend(struct platform_device *pdev, pm_message_t state)
 {
@@ -838,4 +837,4 @@ static struct platform_driver mvebu_gpio_driver = {
 	.suspend        = mvebu_gpio_suspend,
 	.resume         = mvebu_gpio_resume,
 };
-module_platform_driver(mvebu_gpio_driver);
+builtin_platform_driver(mvebu_gpio_driver);
-- 
2.6.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
    Re: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly  non-modular Baruch Siach <baruch@tkos.co.il> - 2016-03-27 19:50 +0200
    Re: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 15:10 +0200
  [PATCH 9/9] drivers/gpio: make gpio-zx.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 5/9] drivers/gpio: make gpio-mvebu.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
    Re: [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 12:10 +0200
  [PATCH 4/9] drivers/gpio: make gpio-moxart.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-03-27 17:50 +0200
  Re: [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij <linus.walleij@linaro.org> - 2016-03-31 15:20 +0200

csiph-web