Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding

From	Matthew McClintock <mmcclint@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding
Date	2016-03-29 00:30 +0200
Message-ID	<rhNPA-56X-7@gated-at.bofh.it> (permalink)
References	<rfZ8u-1se-3@gated-at.bofh.it> <rfZ8v-1se-27@gated-at.bofh.it> <rgAKJ-2QC-1@gated-at.bofh.it> <rhIPT-1EH-5@gated-at.bofh.it> <rhJVE-2nJ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mar 28, 2016, at 1:15 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
>>> What SoC(s) is this in. Use SoC specific compatible strings please.
>> 
>> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
>> 
>> qcom,kpss-ipq4019 ?
>> 
> It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not
> refer to a specific block. Devicetree maintainers may have a better idea,
> but it seems to me that there should be 'wdt' or 'watchdog' in the property
> name.

Sounds fine to me, if no one has any other comments I’ll use this one in the next spin of the patch.

-M

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-23 23:10 +0100
  Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree  binding Rob Herring <robh@kernel.org> - 2016-03-25 15:20 +0100
    Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-28 19:10 +0200
      Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Rob Herring <robh@kernel.org> - 2016-03-28 19:30 +0200
      Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree  binding Guenter Roeck <linux@roeck-us.net> - 2016-03-28 20:20 +0200
        Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-29 00:30 +0200

csiph-web