Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding
Date	2016-03-28 19:30 +0200
Message-ID	<rhJ9f-1LU-11@gated-at.bofh.it> (permalink)
References	<rfZ8u-1se-3@gated-at.bofh.it> <rfZ8v-1se-27@gated-at.bofh.it> <rgAKJ-2QC-1@gated-at.bofh.it> <rhIPT-1EH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 28, 2016 at 12:02 PM, Matthew McClintock
<mmcclint@codeaurora.org> wrote:
> On Mar 25, 2016, at 9:15 AM, Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
>>> Update the compatible string to add new device tree binding
>>>
>>> CC: linux-watchdog@vger.kernel.org
>>> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> index 60bb2f98..45b37cf 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> @@ -6,6 +6,7 @@ Required properties :
>>>
>>>                      "qcom,kpss-timer"
>>>                      "qcom,scss-timer"
>>> +                    "qcom,kpss-standalone"
>>
>> What SoC(s) is this in. Use SoC specific compatible strings please.
>
> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?

Yep, that's how it is supposed to work. Newer chips claim
compatibility with older ones.

> qcom,kpss-ipq4019 ?

Yes, but generally <vendor>,<soc>-<block> is preferred order.

Rob

Thread

[PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-23 23:10 +0100
  Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree  binding Rob Herring <robh@kernel.org> - 2016-03-25 15:20 +0100
    Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-28 19:10 +0200
      Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Rob Herring <robh@kernel.org> - 2016-03-28 19:30 +0200
      Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree  binding Guenter Roeck <linux@roeck-us.net> - 2016-03-28 20:20 +0200
        Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding Matthew McClintock <mmcclint@codeaurora.org> - 2016-03-29 00:30 +0200

csiph-web