RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

From	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value
Date	2016-03-28 12:10 +0200
Message-ID	<rhChs-5v5-15@gated-at.bofh.it> (permalink)
References	(2 earlier) <rgDpg-4Wl-19@gated-at.bofh.it> <rgE1Z-5dh-19@gated-at.bofh.it> <rgSxX-7c3-1@gated-at.bofh.it> <rhzjz-3dm-1@gated-at.bofh.it> <rhASm-4m6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

> Sent: Monday, March 28, 2016 5:30 PM
> 
> Hi,
> 
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
> >> > ps: there might be bugs there, but it's a holiday and I really shouldn't
> >> > be spending time on this right now ;-)
> >>
> >> I'm also off on holiday now until Sunday 10th April... yay :-)
> >> >
> >> > Anyway, have fun testing. Let me know if it doesn't work.
> >>
> >> I only have access to STi platforms which were broken by this change.
> >> Not any of the platforms which rely on the functionality which
> >> was introduced (although I can't see any reason why your patch wouldn't work).
> >>
> >> Maybe Yoshihiro (on CC) could test this on the Renesas platforms and confirm?
> >
> > Thank you for sending the email to me on CC.
> >
> > I tested Felipe's patch on Renesas platfroms (R-Car Gen2 and Gen3) and
> > I fixed the patch like the following.
> >
> > However, my fixes patch might need to clean the code up more.
> >
> > Changes from Felipe's patch:
> > - Change function names of xhci_rcar_init_quirk() to xhci_rcar_setup_quirk()
> 
> I'm not sure renaming that function fits on the same patch ;-) Sounds
> like it should be a separate patch altogether. I'll work on this
> tomorrow if it's okay for you guys to test on your respective platforms :-)

Thank you for the comment!
I also think it should be separate patch ;)
Also I'm okay to test your patch(es) on my platforms :)

Best regards,
Yoshihiro Shimoda

> --
> balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Peter Griffin <peter.griffin@linaro.org> - 2016-03-25 15:50 +0100
  Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-25 18:00 +0100
    Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-03-25 18:10 +0100
      Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-25 18:50 +0100
        Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at  a non zero value Peter Griffin <peter.griffin@linaro.org> - 2016-03-26 10:20 +0100
          Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-26 11:20 +0100
            Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at  a non zero value Lee Jones <lee.jones@linaro.org> - 2016-03-29 11:10 +0200
          RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a  non zero value Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-03-28 09:00 +0200
            RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-28 10:40 +0200
              RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a  non zero value Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-03-28 12:10 +0200

csiph-web