Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364780

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

Show all headers | View raw

Hi Felipe,
 
 On ven., mars 25 2016, Felipe Balbi <balbi@kernel.org> wrote:

> Hi,
>
> Peter Griffin <peter.griffin@linaro.org> writes:
>> Otherwise generic-xhci and xhci-platform which have no data get wrongly
>> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is().
>>
>> This fixes a regression in v4.5 for STiH407 family SoC's which use the
>> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to
>> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never
>> gets added.
>>
>> I suspect this will also fix other dwc3 DT platforms such as Exynos,
>> although I've only tested on STih410 SoC.
>>
>> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv")
>> Cc: stable@vger.kernel.org
>> Cc: gregory.clement@free-electrons.com
>> Cc: yoshihiro.shimoda.uh@renesas.com
>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> ---
>>  drivers/usb/host/xhci-plat.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h
>> index 5a2e2e3..529c3c4 100644
>> --- a/drivers/usb/host/xhci-plat.h
>> +++ b/drivers/usb/host/xhci-plat.h
>> @@ -14,7 +14,7 @@
>>  #include "xhci.h"	/* for hcd_to_xhci() */
>>  
>>  enum xhci_plat_type {
>> -	XHCI_PLAT_TYPE_MARVELL_ARMADA,
>> +	XHCI_PLAT_TYPE_MARVELL_ARMADA = 1,
>>  	XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2,
>>  	XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3,
>
> aren't these platforms using device tree ? Why aren't these just
> different compatible strings ?

According to 4efb2f69411456d35051e9047c15157c9a5ba217 "usb: host:
xhci-plat: add struct xhci_plat_priv" :

This patch adds struct xhci_plat_priv to simplify the code to match
platform specific variables. For now, this patch adds a member "type" in
the structure

Gregory


>
> -- 
> balbi

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Peter Griffin <peter.griffin@linaro.org> - 2016-03-25 15:50 +0100
  Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-25 18:00 +0100
    Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-03-25 18:10 +0100
      Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-25 18:50 +0100
        Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at  a non zero value Peter Griffin <peter.griffin@linaro.org> - 2016-03-26 10:20 +0100
          Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-26 11:20 +0100
            Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at  a non zero value Lee Jones <lee.jones@linaro.org> - 2016-03-29 11:10 +0200
          RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a  non zero value Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-03-28 09:00 +0200
            RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Felipe Balbi <balbi@kernel.org> - 2016-03-28 10:40 +0200
              RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a  non zero value Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2016-03-28 12:10 +0200

csiph-web