Re: [PATCH 1/1] Btrfs: Code Cleanup

From	Petr Tesarik <ptesarik@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] Btrfs: Code Cleanup
Date	2016-03-24 16:10 +0100
Message-ID	<rgf3z-4oM-9@gated-at.bofh.it> (permalink)
References	<reFOx-3wm-5@gated-at.bofh.it> <rgf3z-4oM-1@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Thu, 24 Mar 2016 16:03:07 +0100
David Sterba <dsterba@suse.cz> wrote:

> On Sun, Mar 20, 2016 at 03:11:11PM +0800, Flex Liu wrote:
>[...]
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
> >  	if (seeding_dev) {
> >  		sb->s_flags &= ~MS_RDONLY;
> >  		ret = btrfs_prepare_sprout(root);
> > -		BUG_ON(ret); /* -ENOMEM */
> > +		if (ret) {
> > +			btrfs_abort_transaction(trans, root, ret);
> 
> The transaction abort seems a bit heavy as it will take down the whole
> filesystem. It's called from the device add ioctl, this is a restartable
> operation.
> 
> Unfortunatelly btrfs_prepare_sprout is called after the transaction
> start so btrfs_abort_transaction must be called. To avoid it, the code
> would need to be reorganized, so the memory allocations happen in
> advance.

On the other hand, an abort is still better than a BUG_ON(), and it may
be easier to make incremental improvements.

Just my 2 cents (I haven't tried it),
Petr T

Thread

[PATCH 1/1] Btrfs: Code Cleanup Flex Liu <fliu@novell.com> - 2016-03-20 08:20 +0100
  Re: [PATCH 1/1] Btrfs: Code Cleanup Anand Jain <anand.jain@oracle.com> - 2016-03-21 09:40 +0100
  Re: [PATCH 1/1] Btrfs: Code Cleanup David Sterba <dsterba@suse.cz> - 2016-03-24 16:10 +0100
    Re: [PATCH 1/1] Btrfs: Code Cleanup Petr Tesarik <ptesarik@suse.com> - 2016-03-24 16:10 +0100
      Re: [PATCH 1/1] Btrfs: Code Cleanup David Sterba <dsterba@suse.cz> - 2016-03-24 17:10 +0100

csiph-web