Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361607

Re: [PATCH 1/1] Btrfs: Code Cleanup

From Anand Jain <anand.jain@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] Btrfs: Code Cleanup
Date 2016-03-21 09:40 +0100
Message-ID <rf3xw-2ZN-7@gated-at.bofh.it> (permalink)
References <reFOx-3wm-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Flex,


> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 366b335..5c16f04 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
>   	if (seeding_dev) {
>   		sb->s_flags &= ~MS_RDONLY;

  This is not undone in the failure code. Theoretically
  it should report error during unmount, did you notice ?

  (in general, $subject can be more specific).

Thanks, Anand

>   		ret = btrfs_prepare_sprout(root);
> -		BUG_ON(ret); /* -ENOMEM */
> +		if (ret) {
> +			btrfs_abort_transaction(trans, root, ret);
> +			goto error_trans;
> +		}
>   	}
>
>   	device->fs_devices = root->fs_info->fs_devices;
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] Btrfs: Code Cleanup Flex Liu <fliu@novell.com> - 2016-03-20 08:20 +0100
  Re: [PATCH 1/1] Btrfs: Code Cleanup Anand Jain <anand.jain@oracle.com> - 2016-03-21 09:40 +0100
  Re: [PATCH 1/1] Btrfs: Code Cleanup David Sterba <dsterba@suse.cz> - 2016-03-24 16:10 +0100
    Re: [PATCH 1/1] Btrfs: Code Cleanup Petr Tesarik <ptesarik@suse.com> - 2016-03-24 16:10 +0100
      Re: [PATCH 1/1] Btrfs: Code Cleanup David Sterba <dsterba@suse.cz> - 2016-03-24 17:10 +0100

csiph-web