Re: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length
Date	2016-03-25 16:00 +0100
Message-ID	<rgBns-36A-9@gated-at.bofh.it> (permalink)
References	<rgkZl-8I-17@gated-at.bofh.it> <rgkZl-8I-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 24, 2016 at 10:29:03PM +0100, Heiko Stuebner wrote:
> The emmc-phy occupies a contiguous set of 8 registers inside the general
> register files, so the reg property should specify this.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> This is essential a counter argument for Shawn's move from reg to reg_offset
> in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0].
> With the move under the grf we now also are able to specify this stuff
> cleanly using already present mechanisms.
> 
> Also meant to v4.6-rc before the binding solidifies.
> 
> 
> [0] https://lkml.org/lkml/2016/3/8/114
> 
>  Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length Heiko Stuebner <heiko@sntech.de> - 2016-03-24 22:30 +0100
  Re: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy  register offset and length Rob Herring <robh@kernel.org> - 2016-03-25 16:00 +0100

csiph-web