Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1362769

Re: [PATCH] firewire: nosy: Replace timeval with timespec64

From Stefan Richter <stefanr@s5r6.in-berlin.de>
Newsgroups linux.kernel
Subject Re: [PATCH] firewire: nosy: Replace timeval with timespec64
Date 2016-03-22 15:30 +0100
Message-ID <rfvtM-5K4-21@gated-at.bofh.it> (permalink)
References <rf12F-1g9-1@gated-at.bofh.it> <rfe9A-1Rp-15@gated-at.bofh.it> <rfesX-2eY-23@gated-at.bofh.it> <rffIm-30V-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mar 21 Arnd Bergmann wrote:
>>> On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote:  
>>>> 'struct timeval' uses a 32 bit field for its 'seconds' value which
>>>> will overflow in year 2038 and beyond. This patch replaces the use
>>>> of timeval in nosy.c with timespec64 which doesn't suffer from y2038
>>>> issue. The code is correct as is - since it is only using the
>>>> microseconds portion of timeval. However, this patch does the
>>>> replacement as part of a larger effort to remove all instances of
>>>> 'struct timeval' from the kernel (that would help identify cases
>>>> where the code is actually broken).
>>>> 
>>>> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
[...]
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Committed to linux1394.git.
I will try to get this pulled upstream in the next few days.
-- 
Stefan Richter
-======----- --== =-==-
http://arcgraph.de/sr/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] firewire: nosy: Replace timeval with timespec64 Tina Ruchandani <ruchandani.tina@gmail.com> - 2016-03-21 07:00 +0100
  Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2016-03-21 21:00 +0100
    Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Stefan Richter <stefanr@s5r6.in-berlin.de> - 2016-03-21 21:20 +0100
      Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2016-03-21 22:40 +0100
        Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Stefan Richter <stefanr@s5r6.in-berlin.de> - 2016-03-22 15:30 +0100

csiph-web