Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361526

[PATCH] firewire: nosy: Replace timeval with timespec64

Show all headers | View raw

'struct timeval' uses a 32 bit field for its 'seconds' value which
will overflow in year 2038 and beyond. This patch replaces the use
of timeval in nosy.c with timespec64 which doesn't suffer from y2038
issue. The code is correct as is - since it is only using the
microseconds portion of timeval. However, this patch does the
replacement as part of a larger effort to remove all instances of
'struct timeval' from the kernel (that would help identify cases
where the code is actually broken).

Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
---
 drivers/firewire/nosy.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index 8a46077..631c977 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -446,14 +446,16 @@ static void
 bus_reset_irq_handler(struct pcilynx *lynx)
 {
 	struct client *client;
-	struct timeval tv;
+	struct timespec64 ts64;
+	u32    timestamp;

-	do_gettimeofday(&tv);
+	ktime_get_real_ts64(&ts64);
+	timestamp = ts64.tv_nsec / NSEC_PER_USEC;

 	spin_lock(&lynx->client_list_lock);

 	list_for_each_entry(client, &lynx->client_list, link)
-		packet_buffer_put(&client->buffer, &tv.tv_usec, 4);
+		packet_buffer_put(&client->buffer, &timestamp, 4);

 	spin_unlock(&lynx->client_list_lock);
 }
--
2.8.0.rc3.226.g39d4020

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] firewire: nosy: Replace timeval with timespec64 Tina Ruchandani <ruchandani.tina@gmail.com> - 2016-03-21 07:00 +0100
  Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2016-03-21 21:00 +0100
    Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Stefan Richter <stefanr@s5r6.in-berlin.de> - 2016-03-21 21:20 +0100
      Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Arnd Bergmann <arnd@arndb.de> - 2016-03-21 22:40 +0100
        Re: [PATCH] firewire: nosy: Replace timeval with timespec64 Stefan Richter <stefanr@s5r6.in-berlin.de> - 2016-03-22 15:30 +0100

csiph-web