Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
Date	2016-03-22 09:40 +0100
Message-ID	<rfq14-1Ol-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <rfaIG-8aj-31@gated-at.bofh.it> <rfcAO-Zv-25@gated-at.bofh.it> <rfgbn-3qY-1@gated-at.bofh.it> <rfgbo-3qY-17@gated-at.bofh.it> <rfgl4-3uK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 21 Mar 2016, Andi Kleen wrote:
> On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote:
> > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > >> Please add a patch before this one that renames gs to gsbase.  This is
> > >> unreadable as is.
> > >
> > > I investigated this now, and it's not straight forward because on 32bit
> > > ->gs is actually gsindex, not gsbase. So with a straight rename you
> > > would end up with index in base on 32bit, which would be confusing.
> > >
> > 
> > I would take this inconsistency as a reason why this needs to be fixed
> > before any further changes are made.
> 
> The patchkit doesn't change anything for 32bit, so any inconsistency
> in 32bit is completely orthogonal.
> 
> I don't see how adding a bazillion unrelated changes makes this
> patchkit any better.

The general rule is that we do necessary cleanups before we change or add new
functionality. That's nothing which can be negotiated. Period.

Thanks,

	tglx

Thread

[PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 17:20 +0100
  Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 19:20 +0100
    Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 20:30 +0100
      Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 20:30 +0100
    Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 23:10 +0100
      Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 23:10 +0100
        Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 23:20 +0100
          Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Thomas Gleixner <tglx@linutronix.de> - 2016-03-22 09:40 +0100
          Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Brian Gerst <brgerst@gmail.com> - 2016-03-22 15:50 +0100

csiph-web