Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1362177
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base |
| Date | 2016-03-21 23:20 +0100 |
| Message-ID | <rfgl4-3uK-19@gated-at.bofh.it> (permalink) |
| References | <rfaIF-8aj-3@gated-at.bofh.it> <rfaIG-8aj-31@gated-at.bofh.it> <rfcAO-Zv-25@gated-at.bofh.it> <rfgbn-3qY-1@gated-at.bofh.it> <rfgbo-3qY-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote: > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@firstfloor.org> wrote: > >> Please add a patch before this one that renames gs to gsbase. This is > >> unreadable as is. > > > > I investigated this now, and it's not straight forward because on 32bit > > ->gs is actually gsindex, not gsbase. So with a straight rename you > > would end up with index in base on 32bit, which would be confusing. > > > > I would take this inconsistency as a reason why this needs to be fixed > before any further changes are made. The patchkit doesn't change anything for 32bit, so any inconsistency in 32bit is completely orthogonal. I don't see how adding a bazillion unrelated changes makes this patchkit any better. > > The variables should be called "gsbase" and "gsindex", full stop. > It's not particularly risky -- we could even compare the generated > code if we cared. Iff you can catch all the ifdefs ... I looked through the grep hits and I don't think it's straight forward. -Andi -- ak@linux.intel.com -- Speaking for myself only.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 17:20 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 19:20 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 20:30 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 20:30 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 23:10 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andy Lutomirski <luto@amacapital.net> - 2016-03-21 23:10 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Andi Kleen <andi@firstfloor.org> - 2016-03-21 23:20 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Thomas Gleixner <tglx@linutronix.de> - 2016-03-22 09:40 +0100
Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base Brian Gerst <brgerst@gmail.com> - 2016-03-22 15:50 +0100
csiph-web