Re: net/sctp: stack-out-of-bounds in sctp_getsockopt

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: net/sctp: stack-out-of-bounds in sctp_getsockopt
Date	2016-03-23 18:40 +0100
Message-ID	<rfUVc-6Rl-5@gated-at.bofh.it> (permalink)
References	<rfw6u-6gB-3@gated-at.bofh.it> <rfwpQ-6oT-5@gated-at.bofh.it> <rfwpQ-6oT-3@gated-at.bofh.it> <rfU8P-6dp-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 24, 2016 at 12:42:43AM +0800, Baozeng wrote:
> 2016-03-22 23:27 GMT+08:00 Eric Dumazet <eric.dumazet@gmail.com>:
> > Untested patch would be :
> >
> > diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> > index 67b2e27999aa..fceb7354d169 100644
> > --- a/net/bridge/netfilter/ebtables.c
> > +++ b/net/bridge/netfilter/ebtables.c
> > @@ -346,7 +346,7 @@ find_inlist_lock(struct list_head *head, const char *name, const char *prefix,
> >  {
> >         return try_then_request_module(
> >                         find_inlist_lock_noload(head, name, error, mutex),
> > -                       "%s%s", prefix, name);
> > +                       "%.*s%s", EBT_TABLE_MAXNAMELEN, prefix, name);
> >  }
> >
> >  static inline struct ebt_table *
> >
> >
> 
> Thanks for your quick patch. I tested it but it still reproduce the
> bug. We should limit the length of the name,
> not the prefix. The following patch fixs it.

Could you give a try to this patch? Thanks.

Thread

net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng Ding <sploving1@gmail.com> - 2016-03-22 16:10 +0100
  Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-22 16:30 +0100
    Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng <sploving1@gmail.com> - 2016-03-23 17:50 +0100
      Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-23 18:20 +0100
      Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Pablo Neira Ayuso <pablo@netfilter.org> - 2016-03-23 18:40 +0100
        Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng <sploving1@gmail.com> - 2016-03-24 06:10 +0100
  Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-22 16:30 +0100
    Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-03-22 16:30 +0100

csiph-web