Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1363563
| From | Eric Dumazet <eric.dumazet@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: net/sctp: stack-out-of-bounds in sctp_getsockopt |
| Date | 2016-03-23 18:20 +0100 |
| Message-ID | <rfUBQ-6HY-3@gated-at.bofh.it> (permalink) |
| References | <rfw6u-6gB-3@gated-at.bofh.it> <rfwpQ-6oT-5@gated-at.bofh.it> <rfwpQ-6oT-3@gated-at.bofh.it> <rfU8P-6dp-43@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 2016-03-24 at 00:42 +0800, Baozeng wrote:
> Thanks for your quick patch. I tested it but it still reproduce the
> bug. We should limit the length of the name,
> not the prefix. The following patch fixs it.
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 67b2e27..4837425 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -346,7 +346,7 @@ find_inlist_lock(struct list_head *head, const
> char *name, const char *prefix,
> {
> return try_then_request_module(
> find_inlist_lock_noload(head, name, error, mutex),
> - "%s%s", prefix, name);
> + "%s%.*s", prefix, EBT_TABLE_MAXNAMELEN, name);
> }
>
Right you are, please send a formal patch ?
Thanks !
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng Ding <sploving1@gmail.com> - 2016-03-22 16:10 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-22 16:30 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng <sploving1@gmail.com> - 2016-03-23 17:50 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-23 18:20 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Pablo Neira Ayuso <pablo@netfilter.org> - 2016-03-23 18:40 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Baozeng <sploving1@gmail.com> - 2016-03-24 06:10 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Eric Dumazet <eric.dumazet@gmail.com> - 2016-03-22 16:30 +0100
Re: net/sctp: stack-out-of-bounds in sctp_getsockopt Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-03-22 16:30 +0100
csiph-web