Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363459

Re: [PATCH] regmap: mmio: Fix value endianness selection

Show all headers | View raw

On Wednesday 23 March 2016 13:17:59, Mark Brown wrote:
> Currently when selecting value endianness we check the register
> endiannes, not the value endianness.
> 
> Reported-by: Alexander Stein <alexander.stein@systec-electronic.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Mh, while this _does_ fix the problem regarding accessing SCFG peripheral 
using syscon, it _does not_ fix the access for spi-fsl-dspi, this is still 
using little-endian.
The difference in those drivers is that syscon manually sets 
config.val_format_endian before calling regmap_init_mmio.
spi-fsl-dspi does not. I guess this driver relies on this configuration being 
done in regmap_get_val_endian. But this is never reached because after setting 
map->reg_read this code is skipped due to "goto skip_format_initialization;"
IMHO a call to regmap_get_val_endian should be added to 
regmap_mmio_gen_context.

Best regards,
Alexander

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regmap: mmio: Fix value endianness selection Mark Brown <broonie@kernel.org> - 2016-03-23 14:20 +0100
  Re: [PATCH] regmap: mmio: Fix value endianness selection Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-23 14:40 +0100
  Applied "regmap: mmio: Fix value endianness selection" to the regmap tree Mark Brown <broonie@kernel.org> - 2016-03-23 14:50 +0100
  Re: [PATCH] regmap: mmio: Fix value endianness selection Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-23 15:30 +0100
    Re: [PATCH] regmap: mmio: Fix value endianness selection Mark Brown <broonie@kernel.org> - 2016-03-25 12:30 +0100
      Re: [PATCH] regmap: mmio: Fix value endianness selection Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-29 08:20 +0200
        Re: [PATCH] regmap: mmio: Fix value endianness selection Stefan Agner <stefan@agner.ch> - 2016-03-29 08:20 +0200

csiph-web