Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360836

Re: [PATCH] mac80211: fix order of flag descriptions

Show all headers | View raw

On 18/03/16 17:46, Joe Perches wrote:
> On Fri, 2016-03-18 at 17:40 +0000, Luis de Bethencourt wrote:
>> On 18/03/16 17:29, Joe Perches wrote:
>>> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>>>> Fix order of mac80211_rx_flags description to match the enum.
> []
>>>> I want ahead and fixed the order of the descriptions. checkpatch.pl was giving
>>>> a warning to my previous patch and I had a hunch it was because the wrong order
>>>> breaks the parser. Indeed it does and with this patch below checkpatch.pl does
>>>> not complain about this flag descriptions anymore.
>>> checkpatch complains?  About what?
>> warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags'
> 
> That's not a checkpatch warning.
> 
> cheers, Joe
> 

Oh no!

Joe is right. That isn't a checkpatch warning, but checkpatch just printing the line
in my commit message that goes over 75 characters. Which I kept that big to keep the
format from make htmldocs.

I still think the order of the documentation should match the enum regardless, it is
nicer for developers reading the code.

Sorry :( my bad for misinterpreting checkpatch's output.

Thanks you Joe for correcting me,
Luis 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 17:10 +0100
  [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 17:40 +0100
    Re: [PATCH] mac80211: fix order of flag descriptions Johannes Berg <johannes@sipsolutions.net> - 2016-03-18 17:50 +0100
      Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
        Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 19:30 +0100
    Re: [PATCH] mac80211: fix order of flag descriptions Joe Perches <joe@perches.com> - 2016-03-18 18:30 +0100
      Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
        Re: [PATCH] mac80211: fix order of flag descriptions Joe Perches <joe@perches.com> - 2016-03-18 18:50 +0100
          Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
  Re: [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 20:00 +0100

csiph-web