Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360834

Re: [PATCH] mac80211: fix order of flag descriptions

Show all headers | View raw

On 18/03/16 16:49, Johannes Berg wrote:
> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>> Fix order of mac80211_rx_flags description to match the enum.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>> Hi,
>>
>> I want ahead and fixed the order of the descriptions. checkpatch.pl
>> was giving
>> a warning to my previous patch and I had a hunch it was because the
>> wrong order
>> breaks the parser. Indeed it does and with this patch below
>> checkpatch.pl does
>> not complain about this flag descriptions anymore.
>>
> Huh. I think we should fix checkpatch.pl instead. While the current
> order isn't likely really good, I believe kernel-doc will output the
> documentation in the order it's listed, and that can be useful for the
> documentation output to group related things, even if their bits may be
> further apart.
> 
> johannes
> 

I agree checkpatch.pl should be fixed. I can look into it. No promises
though, it has been a long time since I look at Perl code.

I understand the logic of grouping the documentation in logical blocks.
It is unfortunate though that this means the enum and documentation won't
match, which makes reading the code harder.

In this particular case I don't see the order of the documentation broken
because flags are being grouped.

Thanks for the review :)
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 17:10 +0100
  [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 17:40 +0100
    Re: [PATCH] mac80211: fix order of flag descriptions Johannes Berg <johannes@sipsolutions.net> - 2016-03-18 17:50 +0100
      Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
        Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 19:30 +0100
    Re: [PATCH] mac80211: fix order of flag descriptions Joe Perches <joe@perches.com> - 2016-03-18 18:30 +0100
      Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
        Re: [PATCH] mac80211: fix order of flag descriptions Joe Perches <joe@perches.com> - 2016-03-18 18:50 +0100
          Re: [PATCH] mac80211: fix order of flag descriptions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 18:50 +0100
  Re: [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-18 20:00 +0100

csiph-web