Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

Path	csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings
Date	Thu, 17 Mar 2016 03:10:02 +0100
Message-ID	<rdvxU-Rq-7@gated-at.bofh.it> (permalink)
References	<rdvxU-Rq-9@gated-at.bofh.it>
X-Original-To	Gavin O'Leary <gavinoleary3@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	david.kershner@unisys.com, benjamin.romer@unisys.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 16 Mar 2016 19:06:50 -0700
X-Original-Message-ID	<20160317020650.GA18660@kroah.com>
X-Original-References	<1458180111-6403-1-git-send-email-gavinoleary3@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1359528

Show key headers only | View raw

On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote:
> Fixed block comment checkpatch warnings.
> 
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..eefbacc 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
>  				}
>  				if (found_mc)
>  					break;	/* accept packet, dest
> -						   matches a multicast
> -						   address */
> +						 * matches a multicast
> +						 * address
> +						 */

That looks horrible, don't you think?

>  			}
>  		} else if (skb->pkt_type == PACKET_HOST) {
>  			break;	/* accept packet, h_dest must match vnic
> -				   mac address */
> +				 * mac address
> +				 */

Same here.

Please fix up to look better, that's your goal, right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment  coding style warnings Greg KH <gregkh@linuxfoundation.org> - 2016-03-17 03:10 +0100

csiph-web