Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment coding style warnings
Date	2016-03-17 03:10 +0100
Message-ID	<rdvxU-Rq-7@gated-at.bofh.it> (permalink)
References	<rdvxU-Rq-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 16, 2016 at 07:01:51PM -0700, Gavin O'Leary wrote:
> Fixed block comment checkpatch warnings.
> 
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..eefbacc 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1315,12 +1315,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
>  				}
>  				if (found_mc)
>  					break;	/* accept packet, dest
> -						   matches a multicast
> -						   address */
> +						 * matches a multicast
> +						 * address
> +						 */

That looks horrible, don't you think?

>  			}
>  		} else if (skb->pkt_type == PACKET_HOST) {
>  			break;	/* accept packet, h_dest must match vnic
> -				   mac address */
> +				 * mac address
> +				 */

Same here.

Please fix up to look better, that's your goal, right?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: staging: unisys: visornic: Fixed block comment  coding style warnings Greg KH <gregkh@linuxfoundation.org> - 2016-03-17 03:10 +0100

csiph-web