Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360418

Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()

Show all headers | View raw

On Thu, Mar 17, 2016 at 02:33:50PM -0700, Joe Perches wrote:
> On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote:
> > 2016-03-17 Joe Perches <joe@perches.com>:
> > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
> > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches <joe@perches.com> wrote:
> > > []
> > > > > It's a name that seems like it should be a straightforward
> > > > > cast of a kernel pointer to a __user pointer like:
> > > > > 
> > > > > static inline void __user *to_user_ptr(void *p)
> > > > > {
> > > > >         return (void __user *)p;
> > > > > }
> > > > ahh, ok.  I guess I was used to using it in the context of ioctl
> > > > structs..  in that context u64 -> (void __user *) made more sense.
> > > > 
> > > > Maybe uapi_to_ptr()?  (ok, not super-creative.. maybe someone has a
> > > > better idea)
> > > Maybe u64_to_user_ptr?
> > That is a good name. If everyone agrees I can resend this patch
> > changing it to u64_to_user_ptr. Then should we still keep it on
> > kernel.h?
> 
> I've no particular opinion about location,
> but maybe compat.h might be appropriate.
> 
> Maybe add all variants:
> 
> 	void __user *u32_to_user_ptr(u32 val)
> 	void __user *u64_to_user_ptr(u64 val)
> 	u32 user_ptr_to_u32(void __user *p)
> 	u64 user_ptr_to_u64(void __user *p)
> 
> Maybe there's something about 32 bit userspace on
> 64 OS that should be done too.

Tbh I really don't think we should add 32bit variants and encourage the
mispractice of having 32bit user ptrs in ioctl structs and stuff. Anyway,
just my bikeshed on top ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v9 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 18:40 +0100
  [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 18:40 +0100
    Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches <joe@perches.com> - 2016-03-17 18:50 +0100
      Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-03-17 19:10 +0100
        Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 19:50 +0100
          Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches <joe@perches.com> - 2016-03-17 21:30 +0100
            Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Rob Clark <robdclark@gmail.com> - 2016-03-17 21:40 +0100
              Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches <joe@perches.com> - 2016-03-17 21:50 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Rob Clark <robdclark@gmail.com> - 2016-03-17 22:00 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches <joe@perches.com> - 2016-03-17 22:20 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 22:20 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Rob Clark <robdclark@gmail.com> - 2016-03-17 22:30 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Joe Perches <joe@perches.com> - 2016-03-17 22:40 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 23:20 +0100
                Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Daniel Vetter <daniel@ffwll.ch> - 2016-03-18 09:30 +0100
  [PATCH v9 3/3] staging/android: refactor SYNC IOCTLs Gustavo Padovan <gustavo@padovan.org> - 2016-03-17 18:40 +0100

csiph-web