Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360250

Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single

Show all headers | View raw

On Thu, Mar 17, 2016 at 06:02:15PM -0400, Sinan Kaya wrote:
> Getting ready to remove dma_to_phys API. Drivers should not be
> using this API for DMA operations. Instead, they should go
> through the dma_map or dma_alloc APIs.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
>  drivers/crypto/marvell/cesa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c
> index c0656e7..52ddfa4 100644
> --- a/drivers/crypto/marvell/cesa.c
> +++ b/drivers/crypto/marvell/cesa.c
> @@ -350,8 +350,8 @@ static int mv_cesa_get_sram(struct platform_device *pdev, int idx)
>  	if (IS_ERR(engine->sram))
>  		return PTR_ERR(engine->sram);
>  
> -	engine->sram_dma = phys_to_dma(cesa->dev,
> -				       (phys_addr_t)res->start);
> +	engine->sram_dma = dma_map_single(cesa->dev, engine->sram,
> +					  DMA_TO_DEVICE);

Documentation/DMA-API.txt

dma_addr_t
dma_map_single(struct device *dev, void *cpu_addr, size_t size,
                      enum dma_data_direction direction)

Notes:  Not all memory regions in a machine can be mapped by this API.
Further, contiguous kernel virtual space may not be contiguous as
physical memory.  Since this API does not provide any scatter/gather
capability, it will fail if the user tries to map a non-physically
contiguous piece of memory.  For this reason, memory to be mapped by
this API should be obtained from sources which guarantee it to be
physically contiguous (like kmalloc).

Specifically, ioremapped memory will *not* work as you expect with
dma_map_single().

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single Sinan Kaya <okaya@codeaurora.org> - 2016-03-17 23:10 +0100
  [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Sinan Kaya <okaya@codeaurora.org> - 2016-03-17 23:10 +0100
    Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Robin Murphy <robin.murphy@arm.com> - 2016-03-18 13:20 +0100
      Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Sinan Kaya <okaya@codeaurora.org> - 2016-03-18 16:10 +0100
        Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Konrad Rzeszutek Wilk <konrad@kernel.org> - 2016-03-28 20:30 +0200
          Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma  functions Stefano Stabellini <sstabellini@kernel.org> - 2016-03-29 14:50 +0200
            Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Sinan Kaya <okaya@codeaurora.org> - 2016-03-29 15:00 +0200
          Re: [PATCH 2/3] swiotlb: prefix dma_to_phys and phys_to_dma functions Arnd Bergmann <arnd@arndb.de> - 2016-03-29 21:40 +0200
  [PATCH 3/3] dma-mapping: move swiotlb dma-phys functions to common header Sinan Kaya <okaya@codeaurora.org> - 2016-03-17 23:10 +0100
    Re: [PATCH 3/3] dma-mapping: move swiotlb dma-phys functions to  common header Robin Murphy <robin.murphy@arm.com> - 2016-03-18 12:40 +0100
      Re: [PATCH 3/3] dma-mapping: move swiotlb dma-phys functions to  common header Sinan Kaya <okaya@codeaurora.org> - 2016-03-18 15:00 +0100
  Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-03-18 00:00 +0100
    Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single okaya@codeaurora.org - 2016-03-18 00:20 +0100
      Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-03-18 01:00 +0100
        Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-18 10:40 +0100
          Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Robin Murphy <robin.murphy@arm.com> - 2016-03-18 12:30 +0100
            Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-18 12:40 +0100
            Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Sinan Kaya <okaya@codeaurora.org> - 2016-03-18 15:00 +0100
              Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Sinan Kaya <okaya@codeaurora.org> - 2016-03-18 15:10 +0100
              Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Sinan Kaya <okaya@codeaurora.org> - 2016-03-18 15:30 +0100
              Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with  dma_map_single Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-03-18 15:30 +0100

csiph-web