Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy
Date	Thu, 17 Mar 2016 16:50:02 +0100
Message-ID	<rdIls-MU-15@gated-at.bofh.it> (permalink)
References	<rdjn4-Vw-25@gated-at.bofh.it> <rdCSK-5Ht-11@gated-at.bofh.it> <rdDvr-6cc-5@gated-at.bofh.it> <rdEhP-6LW-3@gated-at.bofh.it> <rdFnB-7qC-37@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qABWltju4eaUXBmg"
Content-Disposition	inline
X-Cookie	Walk softly and carry a megawatt laser.
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP	2a01:348:6:8808:fab::3
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	"Pan, Harry" <harry.pan@intel.com>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "gs0622@gmail.com" <gs0622@gmail.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "tiwai@suse.com" <tiwai@suse.com>, "perex@perex.cz" <perex@perex.cz>
X-Original-Date	Thu, 17 Mar 2016 15:42:36 +0000
X-Original-Message-ID	<20160317154236.GH2566@sirena.org.uk>
X-Original-References	<1458127071-14417-1-git-send-email-harry.pan@intel.com> <20160317095438.GD2566@sirena.org.uk> <1458211115.965.13.camel@intel.com> <20160317112514.GE2566@sirena.org.uk> <56EAA4FC.5090408@metafoo.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1359968

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 17, 2016 at 01:37:16PM +0100, Lars-Peter Clausen wrote:

> I'd say as a quick fix for stable check that card is not NULL in
> dapm_widget_show_component(). And as a longterm fix get rid of dapm_widget
> file. Nobody should hopefully use it anymore with debugfs being available as
> the far better alternative.

Getting rid of the file is definitely not a bad idea but I'd still like
to see us make the dummy component more consistent with other components
in order to minimise the chances that we'll run into other special
cases.

Thread

[PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Harry Pan <harry.pan@intel.com> - 2016-03-16 14:10 +0100
  Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 11:00 +0100
    Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy "Pan, Harry" <harry.pan@intel.com> - 2016-03-17 11:40 +0100
      Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 12:30 +0100
        Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Lars-Peter Clausen <lars@metafoo.de> - 2016-03-17 13:40 +0100
          Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy "Pan, Harry" <harry.pan@intel.com> - 2016-03-17 14:10 +0100
          Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 16:50 +0100
            Re: [alsa-devel] [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy Vinod Koul <vinod.koul@linux.intel.com> - 2016-03-18 06:20 +0100

csiph-web