Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy
Date	2016-03-17 12:30 +0100
Message-ID	<rdEhP-6LW-3@gated-at.bofh.it> (permalink)
References	<rdjn4-Vw-25@gated-at.bofh.it> <rdCSK-5Ht-11@gated-at.bofh.it> <rdDvr-6cc-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 17, 2016 at 10:38:36AM +0000, Pan, Harry wrote:

> Allow me to explain more detail that I saw during debug; since the
> commit 6e78108bda78 (ASoC: core: Don't probe the component which is
> dummy), an exception has been made that dummy component won't be probed,
> thus the 'card' passed into soc_probe_component() would not be assigned
> to this component. In the other hand, the component struct is initially
> created in snd_soc_register_platform() by kzalloc() of platform struct,
> its 'card' pointer is remaining an NULL pointer even the widget node
> being read.

> Perhaps another option is to refine soc_probe_component(), which I have
> not dive in.

Another approach might be to create a separate dummy component for each
card rather than trying to reuse the same one for all of them (which was
what the commit you mention was doing) - that way we don't need to worry
about it getting added to multiple cards which was the original problem
that was being looked at here.

Thread

[PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Harry Pan <harry.pan@intel.com> - 2016-03-16 14:10 +0100
  Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 11:00 +0100
    Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy "Pan, Harry" <harry.pan@intel.com> - 2016-03-17 11:40 +0100
      Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 12:30 +0100
        Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Lars-Peter Clausen <lars@metafoo.de> - 2016-03-17 13:40 +0100
          Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy "Pan, Harry" <harry.pan@intel.com> - 2016-03-17 14:10 +0100
          Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy Mark Brown <broonie@kernel.org> - 2016-03-17 16:50 +0100
            Re: [alsa-devel] [PATCH] ASoC: dapm: Do not traverse widget hooks to  snd-soc-dummy Vinod Koul <vinod.koul@linux.intel.com> - 2016-03-18 06:20 +0100

csiph-web