Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.
Date	2016-03-17 15:50 +0100
Message-ID	<rdHpn-di-5@gated-at.bofh.it> (permalink)
References	<rdBjY-4LR-7@gated-at.bofh.it> <rdCg3-5qo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Julian Calaby <julian.calaby@gmail.com> writes:
> Hi Jandy,
>
> On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou <qingsong.gou@ck-telecom.com> wrote:
>> make C=1 M=drivers/staging/rtl8723au/
>>
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
>> restricted __le16
>> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
>> restricted __le32
>>
>> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
>
> I'm not sure your change is correct. Perhaps you should add temporary
> variables for h2c_cmd_ex and h2c_cmd while they're cpu-endian?
>
> Jes,
>
> I'm pretty sure this isn't the first time this has come up. Do you
> have any ideas for a solution? Or should we ignore this as this driver
> will eventually be going away?

Temp variables as you suggest would be a clean way to accomplish this.

Technically this might work, but esthetically this is so gross I wish I
had never seen it. There is a reason why we have the byteorder specific
types, and le{16,32}_to_cpus() violates that.

I am surprised we still have these macros around, tbh I didn't even know
they existed. A quick search for le16_to_cpus() shows that it's really
very old drivers and some more recent Intel Ethernet drivers that use
them - maybe this would be a good time to get rid of them completely.

Cheers,
Jes

Thread

[PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jandy Gou <qingsong.gou@ck-telecom.com> - 2016-03-17 09:20 +0100
  Re: [PATCH] staging: r8723au: This patch tries to fix some byte order  issues that is found by sparse check. Julian Calaby <julian.calaby@gmail.com> - 2016-03-17 10:20 +0100
    Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-03-17 15:50 +0100
  Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-03-17 15:40 +0100

csiph-web