Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.
Date	2016-03-17 15:40 +0100
Message-ID	<rdHfH-9X-1@gated-at.bofh.it> (permalink)
References	<rdBjY-4LR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Jandy Gou <qingsong.gou@ck-telecom.com> writes:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou <qingsong.gou@ck-telecom.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> index 1662c03c..d82fd8a 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> @@ -93,11 +93,11 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen,
>  
>  		if (h2c_cmd & BIT(7)) {
>  			msgbox_ex_addr = REG_HMEBOX_EXT_0 + (h2c_box_num * EX_MESSAGE_BOX_SIZE);
> -			h2c_cmd_ex = le16_to_cpu(h2c_cmd_ex);
> +			le16_to_cpus(&h2c_cmd_ex);
>  			rtl8723au_write16(padapter, msgbox_ex_addr, h2c_cmd_ex);
>  		}
>  		msgbox_addr = REG_HMEBOX_0 + (h2c_box_num * MESSAGE_BOX_SIZE);
> -		h2c_cmd = le32_to_cpu(h2c_cmd);
> +		le32_to_cpus(&h2c_cmd);
>  		rtl8723au_write32(padapter, msgbox_addr, h2c_cmd);

Please do *not* use le{16,32}_to_cpus() that is so gross it's hard to
even put words on it. Use a temp variable of the correct type instead.

NAK

Jes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jandy Gou <qingsong.gou@ck-telecom.com> - 2016-03-17 09:20 +0100
  Re: [PATCH] staging: r8723au: This patch tries to fix some byte order  issues that is found by sparse check. Julian Calaby <julian.calaby@gmail.com> - 2016-03-17 10:20 +0100
    Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-03-17 15:50 +0100
  Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check. Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-03-17 15:40 +0100

csiph-web